MAINT: ensure file is closed - #162
Open
andyfaff wants to merge 1 commit into
Open
Conversation
Collaborator
|
Wouldn't it be cleaner to make this directly in a context manager and with testing for the actual class? No try/except etc required. @contextmanager
def _possibly_open_file(f: Union[TextIO, str], mode: str = "wb") -> Generator[TextIO, None, None]:
"""
...
"""
if not isinstance(f, str): # or alternatively isinstance(f, TextIOBase)
yield f
else:
with open(f, mode) as g:
yield g |
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
2 participants
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
This is needed to ensure that a resource is definitely closed. At the moment the close doesn't happen if there's an exception raised after the yield, but before the file is closed.